-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace instanceof check by Construct.isConstruct call #32353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32353 +/- ##
==========================================
- Coverage 78.46% 78.42% -0.05%
==========================================
Files 106 106
Lines 7208 7208
Branches 1323 1323
==========================================
- Hits 5656 5653 -3
- Misses 1364 1368 +4
+ Partials 188 187 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Reason for this change
Allow to use SelfManagedKafkaEventSource in symlinked setups
Description of changes
Replace instanceof check by
Construct.isConstruct()
call.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license